Bug 1777980: Edge Hack - Fix Pipeline Logs #3612
Conversation
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@andrewballantyne: This pull request references Bugzilla bug 1777980, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
component/dev-console
openshift-ci-robot
added
the
approved
| &.is-edge { | ||
| .pf-c-alert { | ||
| display: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
Not my finest code... but it does prevent this:
Closing of the websocket causes Edge to throw an error which is caught by the error handling and shown on each ResourceLog that is mounted.
|
@andrewballantyne: This pull request references Bugzilla bug 1777980, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
working fine on Edge 18, Win 10 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinandan13jan, andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
11 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@andrewballantyne: All pull requests linked via external trackers have merged. Bugzilla bug 1777980 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.3 |
|
@andrewballantyne: new pull request created: #3621 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@andrewballantyne: Bugzilla bug 1777980 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://jira.coreos.com/browse/ODC-2402
This is what it looks like now:
Will eventually be replaced by https://jira.coreos.com/browse/ODC-2381 which should cover a lot of the short comings of the current Pipeline Logs.