Optimize utilization card by splitting items to smaller components ea… #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/XL
rawagner
force-pushed
the
opt_utilization
branch
from
6bb98a6
to
a25914c
Compare
rawagner
force-pushed
the
opt_utilization
branch
from
a25914c
to
b9eb356
Compare
|
/assign @mareklibra |
openshift-ci-robot
added
component/kubevirt
mareklibra
reviewed
Jan 7, 2020
| humanizeValue={(v) => ({ string: `${v}`, value: v as number, unit: '' })} | ||
| query={queries[HostQuery.NUMBER_OF_PODS].utilization} | ||
| utilizationQuery={queries[HostQuery.NUMBER_OF_PODS].utilization} | ||
| humanizeValue={React.useCallback( |
There was a problem hiding this comment.
Can we move useCallback() up and just pass value here?
| namespace={projectName} | ||
| position={PopoverPosition.top} | ||
| <PrometheusUtilizationItem | ||
| title="Network Transfer in/out" |
There was a problem hiding this comment.
we should have just a Network transfer here, so I changed it accordingly.
…ch fetching its own data
rawagner
force-pushed
the
opt_utilization
branch
from
b9eb356
to
09f1c35
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mareklibra, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ch fetching its own data