Bug 1797379: pipeline test edit1 #4006
Conversation
openshift-ci-robot
added
the
size/XS
|
/test backend |
|
/test e2e-gcp-console |
|
/test backend |
|
@sanketpathak Is there a description or a link around what this PR is trying to do? |
|
Added the description, it's just a slight change in the tests to run the test without any errors |
|
/test e2e-gcp-console |
|
/LGTM |
There was a problem hiding this comment.
Sanket,
I encountered a problem with line 99 in this test:
expect(pipelineOverviewName.getText()).toContain('new-pipeline');
This expect statement ^^^ always failed for me.
I suggest that you replace this line^^^^ with these 2 lines:
await browser.wait(until.elementToBeClickable(pipelineOverviewName));
await browser.wait(until.textToBePresentInElement(pipelineOverviewName, 'new-pipeline'));
There was a problem hiding this comment.
Sanket,
I encountered a problem with line 99 in this test:
expect(pipelineOverviewName.getText()).toContain('new-pipeline');
This expect statement ^^^ always failed for me.
I suggest that you replace this line^^^^ with these 2 lines:
await browser.wait(until.elementToBeClickable(pipelineOverviewName));
await browser.wait(until.textToBePresentInElement(pipelineOverviewName, 'new-pipeline'));
sanketpathak
force-pushed
the
test-pipeline
branch
from
f62fd0f
to
0f96307
Compare
openshift-ci-robot
added
size/S
|
/test e2e-gcp-console |
|
/lgtm Thanks for making the final changes! |
|
/test e2e-gcp-console |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinandan13jan, christianvogt, ldimaggi, sanketpathak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@sanketpathak: This pull request references Bugzilla bug 1797379, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@sanketpathak: This pull request references Bugzilla bug 1797379, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@sanketpathak: All pull requests linked via external trackers have merged. Bugzilla bug 1797379 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Minor addition in pipeline tests to run existing tests flawlessly