Bug 1609204 - Add namespace to pod selector in workload list pages #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
Switches stateful set to WorkloadListRow for consistency |
|
/hold forgot daemon sets |
openshift-ci-robot
added
the
do-not-merge/hold
spadgett
force-pushed
the
pod-selector-resource-list
branch
from
409fcc1 to
dc5a917
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
spadgett
commented
Aug 15, 2018
| </div> | ||
| <div className="col-lg-3 hidden-md hidden-sm hidden-xs"> | ||
| <Selector selector={daemonset.spec.selector} /> | ||
| <Selector selector={daemonset.spec.selector} namespace={daemonset.metadata.namespace} /> |
There was a problem hiding this comment.
Unfortunately, WorkloadListRow doesn't work for daemon sets because the pods column is wrong, so I have to make the fix here, too.
|
jenkins rebuild |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1609204
/assign @TheRealJon