Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1796421: Update serverless apiVersion from v1beta1 to v1 and updates URI acronym #4075

Merged
merged 1 commit into from Jan 31, 2020
Merged

Bug 1796421: Update serverless apiVersion from v1beta1 to v1 and updates URI acronym #4075

merged 1 commit into from Jan 31, 2020

Conversation

invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Jan 27, 2020 •
edited

Updates serverless apiVersion from v1beta1 to v1 and updates URI acronym for Sink Uri

Tracks:

Screenshots:

Screenshot 2020-01-27 at 4 45 53 PM

Screenshot 2020-01-27 at 5 23 34 PM

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2020
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/dev-console Related to dev-console component/knative Related to knative-plugin labels Jan 27, 2020
@invincibleJai
Copy link
Member Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 27, 2020
@invincibleJai invincibleJai changed the title [WIP] serverless apiVersion from v1beta1 to v1 and updates URI acronym Update serverless apiVersion from v1beta1 to v1 and updates URI acronym Jan 27, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2020
rohitkrai03
rohitkrai03 approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2020
@invincibleJai invincibleJai changed the title Update serverless apiVersion from v1beta1 to v1 and updates URI acronym Bug 1796421: Update serverless apiVersion from v1beta1 to v1 and updates URI acronym Jan 30, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 30, 2020
@openshift-ci-robot
Copy link
Contributor

@invincibleJai: This pull request references Bugzilla bug 1796421, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1796421: Update serverless apiVersion from v1beta1 to v1 and updates URI acronym

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karthikjeeyar
Copy link
Contributor

Verified locally
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1f1cc4f into openshift:master Jan 31, 2020
@openshift-ci-robot
Copy link
Contributor

@invincibleJai: All pull requests linked via external trackers have merged. Bugzilla bug 1796421 has been moved to the MODIFIED state.

In response to this:

Bug 1796421: Update serverless apiVersion from v1beta1 to v1 and updates URI acronym

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 4, 2020
@invincibleJai
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@invincibleJai: Bugzilla bug 1796421 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@invincibleJai
Copy link
Member Author

/cherrypick release-4.3

@openshift-cherrypick-robot
Copy link

@invincibleJai: #4075 failed to apply on top of branch "release-4.3":

Using index info to reconstruct a base tree...
M	frontend/packages/dev-console/src/components/topology/__tests__/topology-knative-test-data.ts
M	frontend/packages/knative-plugin/src/components/overview/EventSinkServicesOverviewList.tsx
A	frontend/packages/knative-plugin/src/components/revisions/__tests__/RevisionRow.spec.tsx
A	frontend/packages/knative-plugin/src/components/routes/__tests__/RouteRow.spec.tsx
M	frontend/packages/knative-plugin/src/types.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/knative-plugin/src/types.ts
CONFLICT (content): Merge conflict in frontend/packages/knative-plugin/src/types.ts
CONFLICT (modify/delete): frontend/packages/knative-plugin/src/components/routes/__tests__/RouteRow.spec.tsx deleted in HEAD and modified in serverless apiVersion from v1beta1 to v1 and updates URI acronym. Version serverless apiVersion from v1beta1 to v1 and updates URI acronym of frontend/packages/knative-plugin/src/components/routes/__tests__/RouteRow.spec.tsx left in tree.
CONFLICT (modify/delete): frontend/packages/knative-plugin/src/components/revisions/__tests__/RevisionRow.spec.tsx deleted in HEAD and modified in serverless apiVersion from v1beta1 to v1 and updates URI acronym. Version serverless apiVersion from v1beta1 to v1 and updates URI acronym of frontend/packages/knative-plugin/src/components/revisions/__tests__/RevisionRow.spec.tsx left in tree.
Auto-merging frontend/packages/knative-plugin/src/components/overview/EventSinkServicesOverviewList.tsx
Auto-merging frontend/packages/dev-console/src/components/topology/__tests__/topology-knative-test-data.ts
error: Failed to merge in the changes.
Patch failed at 0001 serverless apiVersion from v1beta1 to v1 and updates URI acronym

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Feb 8, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@sahil143 sahil143 Awaiting requested review from sahil143

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

Assignees

@karthikjeeyar karthikjeeyar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console component/knative Related to knative-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@invincibleJai @openshift-ci-robot @karthikjeeyar @openshift-bot @openshift-cherrypick-robot @rohitkrai03 @spadgett @openshift-merge-robot