Bug 1796450: Disable the zoom feature for QueryBrowser when hideControls props is true

[vikram-raj]

Fixes: https://issues.redhat.com/browse/ODC-2779

Analysis / Root cause:

On the dev-monitoring dashboard, users are able to zoom the graph but there is no option to reset the zoom.

Solution Description:

Disable the zoom feature when hideControls prop is true.

Screen shots / Gifs for design review:

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[spadgett]

FYI, the bot requires Bugzilla bugs for 4.4 fixes going forward (org wide)

cc @kyoto, we'll probably want this for the monitoring dashboards as well

[vikram-raj]

/retitle Bug 1796450: Disable the zoom feature for QueryBrowser when hideControls props is true

[openshift-ci-robot]

@vikram-raj: This pull request references Bugzilla bug 1796450, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1796450: Disable the zoom feature for QueryBrowser when hideControls props is true

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[christianvogt]

Seems ok.
The monitoring dashboard also sets hideControls to true.
@kyoto please review.

[andrewballantyne]

/kind bug

[andrewballantyne]

I have not reviewed this PR, but I noticed something else when I was doing bug triage... The sidebar charts also appear to have a zoom feature compounded with a click handler... can we make sure this is disabled on the sidebar as well @vikram-raj ?

[serenamarie125]

This makes sense. According to the design, users shouldn't be able to drill into individual charts. There should be a dashboard level zoom feature, but that doesn't need to be supported in this PR.

[openshift-ci-robot]

@vikram-raj: This pull request references Bugzilla bug 1796450, which is valid.

In response to this:

Bug 1796450: Disable the zoom feature for QueryBrowser when hideControls props is true

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vikram-raj]

I have not reviewed this PR, but I noticed something else when I was doing bug triage... The sidebar charts also appear to have a zoom feature compounded with a click handler... can we make sure this is disabled on the sidebar as well @vikram-raj ?

Yes, Zoom feature is also disabled for the sidebar as well as same component has been used at both the places. Missed this scenario in the GIF. Updated the GIF.

[kyoto]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, serenamarie125, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/public/components/monitoring/OWNERS [kyoto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@vikram-raj: All pull requests linked via external trackers have merged. Bugzilla bug 1796450 has been moved to the MODIFIED state.

In response to this:

Bug 1796450: Disable the zoom feature for QueryBrowser when hideControls props is true

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.