New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1797567: add unit test for custome hook usePodScalingAccessStatus #4133
Bug 1797567: add unit test for custome hook usePodScalingAccessStatus #4133
Conversation
@sahil143: This pull request references Bugzilla bug 1797567, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
apiCallfn: ( | ||
res: K8sResourceKind, | ||
kind: K8sKind, | ||
impersonate: string, | ||
) => Promise<SelfSubjectAccessReviewKind>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is odd for client code to have to provide this isn't it?
Seems like you are just doing this change so that you can unit test the code.
Why not mock checkPodEditAccess
instead?
/kind bug |
110f033
to
809f14a
Compare
809f14a
to
9e209ed
Compare
9e209ed
to
f10ee7a
Compare
initial test for hooks Initial commit add unit tests for custom hook experimenting update the tests remove apicallfn dependecy remove console.log do lint
f10ee7a
to
dbb258a
Compare
.catch(() => {}); | ||
}); | ||
|
||
it('should have access false if check Access return allowed false', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async test missing done
callback
/retest |
/bugzilla refresh |
@spadgett: This pull request references Bugzilla bug 1797567, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold |
/hold cancel |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Failed on the test right after the one we fixed in #4411 -- maybe a flake... going to try again. |
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@sahil143: All pull requests linked via external trackers have merged. Bugzilla bug 1797567 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fixes: https://issues.redhat.com/browse/ODC-2669
This PR adds unit test for custom hook
usePodScalingAccessStatus
which was missing in PR #3746