New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.3] Bug 1811525: Add Pipeline Resources on Pipelines Resources tab don't work #4473
[release-4.3] Bug 1811525: Add Pipeline Resources on Pipelines Resources tab don't work #4473
Conversation
…ines details page
@karthikjeeyar: This pull request references Bugzilla bug 1807089, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @christianvogt Need Christian or Rohit for 4.3 approvals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, karthikjeeyar, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/assign @knobunc Needs cherry-pick aproved label |
The PR that fixes the dependent bug does not look like this PR and is not linked to the PR that is used for the backport. Is this tied to the wrong BZ? @karthikjeeyar |
@karthikjeeyar @rohitkrai03 can you explain why the PRs for each version is a bit different? Are any of changes from the dependent PRs required? |
We also had this change added in 4.4 and higher, so that we need to have seperate validation schema for parameters and resources. This needed to be backport to 4.3 so that each tabs will have different validation schemes. @shawn-hurley |
/retitle [release-4.3] Bug 1811525: Add Pipeline Resources on Pipelines Resources tab don't work |
@karthikjeeyar: This pull request references Bugzilla bug 1811525, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@karthikjeeyar: This pull request references Bugzilla bug 1811525, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Updated the Bugzilla Id to point the correct dependant bug. |
/test e2e-gcp-console Hit a global limit of resources... |
Hmm... same error as before... perhaps the pool is running at its max? Not sure if there is much to do but wait for resources to be freed up. cc @spadgett are we going to have a growing issue here with CI? |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@karthikjeeyar: All pull requests linked via external trackers have merged. Bugzilla bug 1811525 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR is manual cherrypick of PR #4287
When user click 'Add Pipeline Resources' button on Pipelines -> Resources tab, the changes can't be saved
Problem:
Both pipeline paramaters & resources validation Schema are maintained in same object resulting in validating both required fields in resources tab
Solution:
@rohitkrai03 has seperated the validation schema here in #4287 for openshift 4.4
The PR needs to be backported to 4.3 to address the issue ticket
https://issues.redhat.com/browse/ODC-2881
cc: @andrewballantyne