New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1796185: Add pipeline for resource and runtime #4476
Bug 1796185: Add pipeline for resource and runtime #4476
Conversation
@andrewballantyne: This pull request references Bugzilla bug 1796185, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
frontend/packages/dev-console/src/components/import/pipeline/PipelineTemplate.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/import/pipeline/PipelineTemplate.tsx
Outdated
Show resolved
Hide resolved
9099de1
to
c7a90fd
Compare
/cherry-pick release-4.4 |
@andrewballantyne: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.3 |
@andrewballantyne: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@andrewballantyne: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@andrewballantyne: All pull requests linked via external trackers have merged. Bugzilla bug 1796185 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@andrewballantyne: new pull request created: #4499 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@andrewballantyne: #4476 failed to apply on top of branch "release-4.3":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-2880
Analysis / Root cause:
The add flow Pipeline doesn't understand the difference between each resource type. The
openshift
Pipelines installed by the Operator need to specifically handle the deploy step specific to the resource type.Solution Description:
We added another label to the
openshift
Pipelines (or will) that the Operator installs. This will give us two points to draw upon to select a Pipeline for the add flow.Also connects the Pipeline add flow to Knative; which did not exist prior.
Screen shots / Gifs for design review:
No visual change, all the magic is under the hood and shouldn't appear any different to the user. It should be noted though, selecting a resource type will collapse the Pipeline preview. If this is undesirable, I can look to improve that experience.
cc @openshift/team-devconsole-ux
Unit test coverage report:
No tests existed for this case, so I didn't add any. I'll look to see about it though.
Test setup:
** Until an unknown version right now, we lack the type label from the Operator side - so there is fallback code to use a Pipeline without the label if it fails to be found
** To test, you'll need to copy the existing Pipeline and apply the label manually.
openshift
namespaced Pipelines available that have the appropriate runtimeBrowser conformance:
/kind bug