Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring: Remove help text from alerts list and silences list #4760

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Mar 18, 2020

Alerts

alerts

Silences

silences

FYI @cshinn, @sichvoge

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 18, 2020
@kyoto
Copy link
Member Author

kyoto commented Mar 18, 2020

/retest

@kyoto kyoto force-pushed the monitoring-remove-list-pages-help-text branch from 800731d to 87eaec4 Compare March 18, 2020 10:15
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, although thought the info descriptions were helpful. I could understand removing the external link if that was the issue.

@cshinn
Copy link

cshinn commented Mar 18, 2020

/lgtm, although thought the info descriptions were helpful. I could understand removing the external link if that was the issue.

@dtaylor113 the external link was certainly part of it, but we're also looking at standardizing how guidance like this appears in the console. These messages might end up here in some form, but right now I think it's best to remove them so we don't have a seemingly random message on a single page in the console

@dtaylor113
Copy link
Contributor

Thanks for the info. @cshinn :-)

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8a89149 into openshift:master Mar 20, 2020
@kyoto kyoto deleted the monitoring-remove-list-pages-help-text branch March 20, 2020 02:58
@spadgett spadgett added this to the v4.5 milestone Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants