Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create flag for Node Maintenance #4973

Merged
merged 1 commit into from Apr 14, 2020

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Apr 8, 2020

No description provided.

@rawagner
Copy link
Contributor Author

rawagner commented Apr 8, 2020

/assign @jtomasek

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/metal3 Related to metal3-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 8, 2020
Copy link

@jtomasek jtomasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In node detail I am seeing following error:

TypeError: Cannot destructure property 'hasNodeMaintenanceCapability' of 'undefined' as it is undefined.
    at menuActionsCreator (http://localhost:9000/static/metal3-baremetalhost~metal3-baremetalhosts-1d1fc133afd842e8d6bb.js:491:98)
    at http://localhost:9000/static/main-35ed8aabcba26e73f2e1.js:39267:27
    at renderWithHooks (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:269201:18)
    at updateFunctionComponent (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:271018:20)
    at beginWork$1 (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:272591:16)
    at HTMLUnknownElement.callCallback (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:254440:14)
    at Object.invokeGuardedCallbackDev (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:254490:16)
    at invokeGuardedCallback (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:254547:31)
    at beginWork$$1 (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:277310:7)
    at performUnitOfWork (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:276304:12)

@@ -0,0 +1,9 @@
// eslint-disable-next-line @typescript-eslint/ban-ts-ignore
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to move this file into packages/console-shared/src/hooks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved

@rawagner
Copy link
Contributor Author

rawagner commented Apr 9, 2020

In node detail I am seeing following error:

TypeError: Cannot destructure property 'hasNodeMaintenanceCapability' of 'undefined' as it is undefined.
    at menuActionsCreator (http://localhost:9000/static/metal3-baremetalhost~metal3-baremetalhosts-1d1fc133afd842e8d6bb.js:491:98)
    at http://localhost:9000/static/main-35ed8aabcba26e73f2e1.js:39267:27
    at renderWithHooks (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:269201:18)
    at updateFunctionComponent (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:271018:20)
    at beginWork$1 (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:272591:16)
    at HTMLUnknownElement.callCallback (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:254440:14)
    at Object.invokeGuardedCallbackDev (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:254490:16)
    at invokeGuardedCallback (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:254547:31)
    at beginWork$$1 (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:277310:7)
    at performUnitOfWork (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:276304:12)

I was able to reproduce on BMH page, BMN seems to be fine. FIxed the BMH part

@jtomasek
Copy link

jtomasek commented Apr 9, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 9, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2020
Copy link

@jtomasek jtomasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jtomasek, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 92deffe into openshift:master Apr 14, 2020
@spadgett spadgett added this to the v4.5 milestone Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/metal3 Related to metal3-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants