New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create flag for Node Maintenance #4973
Create flag for Node Maintenance #4973
Conversation
/assign @jtomasek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In node detail I am seeing following error:
TypeError: Cannot destructure property 'hasNodeMaintenanceCapability' of 'undefined' as it is undefined.
at menuActionsCreator (http://localhost:9000/static/metal3-baremetalhost~metal3-baremetalhosts-1d1fc133afd842e8d6bb.js:491:98)
at http://localhost:9000/static/main-35ed8aabcba26e73f2e1.js:39267:27
at renderWithHooks (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:269201:18)
at updateFunctionComponent (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:271018:20)
at beginWork$1 (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:272591:16)
at HTMLUnknownElement.callCallback (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:254440:14)
at Object.invokeGuardedCallbackDev (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:254490:16)
at invokeGuardedCallback (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:254547:31)
at beginWork$$1 (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:277310:7)
at performUnitOfWork (http://localhost:9000/static/vendors~main-2d1fca3637bd3cdb7c82.js:276304:12)
@@ -0,0 +1,9 @@ | |||
// eslint-disable-next-line @typescript-eslint/ban-ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to move this file into packages/console-shared/src/hooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved
aaf4c72
to
009eb41
Compare
009eb41
to
f59005e
Compare
I was able to reproduce on BMH page, BMN seems to be fine. FIxed the BMH part |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
f59005e
to
1289c53
Compare
1289c53
to
ba43ed6
Compare
ba43ed6
to
90958ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jtomasek, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
No description provided.