Bug 1824468: Add capacity for Local volume shows NaN TiB #5060
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cloudbehl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Please add the bugzilla id |
cloudbehl
changed the title
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@cloudbehl: This pull request references Bugzilla bug 1824468, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
...packages/ceph-storage-plugin/src/components/modals/add-capacity-modal/add-capacity-modal.tsx
Outdated
Show resolved
Hide resolved
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@cloudbehl: This pull request references Bugzilla bug 1824468, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@cloudbehl: This pull request references Bugzilla bug 1824468, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
Signed-off-by: Ankush Behl <cloudbehl@gmail.com>
cloudbehl
force-pushed
the
add-capacity-raw-bug
branch
from
b45a050
to
d068573
Compare
openshift-ci-robot
removed
the
needs-rebase
There was a problem hiding this comment.
Better to hide the information text of replica.
Hiding the entire text box does not provide much information on error and still a user can proceed with add capacity and mess up the CR.
In the input box you can show the previous value osdSizeWithUnit if it does not matches the supported OSD size.
|
This fix is for OCS 4.4 and in 4.5. This is anyways hidden & the right information is being shown. This is just a very edge case that will not occur in OCS converged mode. The independent for 4.4 shows this crappy NaN which we want to hide because we don't know the size calculation. |
|
Closing this PR. WIll be fixed in 4.5! |
Before
After
Signed-off-by: Ankush Behl cloudbehl@gmail.com