Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1832821: Fix bugs on VM Environment tab #5370

Merged
merged 1 commit into from May 11, 2020
Merged

Bug 1832821: Fix bugs on VM Environment tab #5370

merged 1 commit into from May 11, 2020

Conversation

irosenzw
Copy link
Contributor

  • Change Add button label
  • Fix reload button issue
  • Remove records with only serial-number and no resource
  • Change serial number default length to 6 from 16
  • Force serial number capitalization

Signed-off-by: Ido Rosenzwig irosenzw@redhat.com

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 10, 2020
@openshift-ci-robot
Copy link
Contributor

@irosenzw: This pull request references Bugzilla bug 1832821, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1832821: Fix bugs on VM Environment tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 10, 2020
@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label May 10, 2020
@irosenzw irosenzw force-pushed the change-add-button-vm-env-tab branch from e7ac403 to 03ea9be Compare May 10, 2020 08:51
rawagner
rawagner reviewed May 11, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/src/components/vms/vm-environment/vm-environment-page.tsx Outdated
@@ -377,6 +376,7 @@ const VMEnvironment = withHandlePromise<VMEnvironmentProps>(
firstTitle="configmap / secret / service account"
secondTitle="Serial Number"
addButtonDisabled={addButtonDisabled || inProgress}
addButtonLabel="Add Configmap, Secret or Service Account"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this rather be like this ?

Suggested change
addButtonLabel="Add Configmap, Secret or Service Account"
addButtonLabel="Add Config Map, Secret or Service Account"

@irosenzw irosenzw force-pushed the change-add-button-vm-env-tab branch from 03ea9be to 684db9f Compare May 11, 2020 08:03
@irosenzw
Bug 1832821: Fix bugs on VM Environment tab
bfb855d 
- Change Add button label
- Fix reload button issue
- Remove records with only serial-number and no resource
- Change serial number default length to 6 from 16
- Force serial number capitalization

Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>
@irosenzw irosenzw force-pushed the change-add-button-vm-env-tab branch from 684db9f to bfb855d Compare May 11, 2020 08:07
@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irosenzw, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit fa666d3 into openshift:master May 11, 2020
@openshift-ci-robot
Copy link
Contributor

@irosenzw: All pull requests linked via external trackers have merged: openshift/console#5370. Bugzilla bug 1832821 has been moved to the MODIFIED state.

In response to this:

Bug 1832821: Fix bugs on VM Environment tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawagner rawagner rawagner left review comments

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@rawagner rawagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@irosenzw @openshift-ci-robot @rawagner @spadgett @openshift-merge-robot