Bug 1833845: Update tests for access and volume modes #5372
Conversation
|
@pcbailey: This pull request references Bugzilla bug 1833845, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-low
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@pcbailey: This pull request references Bugzilla bug 1833845, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
| @@ -133,22 +134,23 @@ describe('Kubevirt create VM using wizard', () => { | |||
| it( | |||
| 'ID(CNV-3052) Creates DV with correct accessMode/volumeMode', | |||
| async () => { | |||
| const expectedAccessMode = diskAccessMode.ReadWriteMany.value; | |||
There was a problem hiding this comment.
I think we shouldn't assume that used storage class will support RWM. For example, hostpath-provisioner doesn't.
The reason for resolveStorageDataAttribute is to use accessMode and volume mode based on what is defined in kubevirt-storage-class-defaults CM.
We should add new test that selects accessMode and volumeMode to something other than is defined in the configMap and test that this setting is actually applied and that user is able to override the defaults, which I believe is the idea behind this feature. Regular usesr don't have permissions to edit that storage-defaulst configmap and when they get a DV created by the UI, accessMode and volumeMode is not editable anymore.
pcbailey
force-pushed
the
update-tests-for-access-and-volume-modes
branch
from
c48b299
to
bce7146
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, rhrazdil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@pcbailey: All pull requests linked via external trackers have merged: openshift/console#5372. Bugzilla bug 1833845 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds tests for the addition of the access and volume mode settings in the VM disk modal.