New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1834956: Remove topology text filter from redux and rely on URL search params #5416
Bug 1834956: Remove topology text filter from redux and rely on URL search params #5416
Conversation
@rohitkrai03: This pull request references Bugzilla bug 1834956, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
1 similar comment
/retest |
/assign @jeff-phillips-18 |
frontend/packages/dev-console/src/components/topology/filters/TopologyFilterBar.tsx
Outdated
Show resolved
Hide resolved
8d64901
to
f5e42ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
verified changes locally
Hah, because of changes in /assign @christianvogt |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18, rohitkrai03, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rohitkrai03: All pull requests linked via external trackers have merged: openshift/console#5416. Bugzilla bug 1834956 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes - https://issues.redhat.com/browse/ODC-3825?filter=12346946
Problem - Topology text filter is saved in redux which is why the filter is applied even if user returns to topology after being redirected from an action on another page.
Solution - Remove text filter from redux state completely and move the implementation based on URL search params only.
Screencast -