Bug 1835833: Fix for topology crash on reload #5445
Conversation
openshift-ci-robot
added
kind/bug
|
@jeff-phillips-18: This pull request references Bugzilla bug 1835833, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve /cc @sahil143 |
openshift-ci-robot
added
the
approved
| }: RootState): TopologyFilters => topology.get('filters'); | ||
| export const getTopologyFilters = (state: RootState): TopologyFilters => { | ||
| const topology = state?.plugins?.devconsole?.topology; | ||
| return topology ? topology.get('filters') : DEFAULT_TOPOLOGY_FILTERS; |
There was a problem hiding this comment.
@jeff-phillips-18 If redux store is not initialized and topology is undefined. Shouldn't we check local storage for filters because filter values might be different from DEFAULT_TOPOLOGY_FILTERS? WDYT?
There was a problem hiding this comment.
Agreed. I will update.
jeff-phillips-18
force-pushed
the
bad-state
branch
from
3e00500
to
4102300
Compare
openshift-ci-robot
added
component/knative
| appGrouping: boolean; | ||
| operatorGrouping: boolean; | ||
| helmGrouping: boolean; | ||
| }; |
There was a problem hiding this comment.
Broke out types into a separate file to avoid cyclic imports.
|
/assign @christianvogt |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, invincibleJai, jeff-phillips-18, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@jeff-phillips-18: All pull requests linked via external trackers have merged: openshift/console#5445. Bugzilla bug 1835833 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3845
Analysis / Root cause:
The topology filters state is being pulled from the current UI state. In rare instances on reload, the state is not yet set causing an NPE
Solution Description:
Use optional chaining when getting the filter states and if not set use the default filters state.
/kind bug