New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1792693: add withStartGuide to dev-console pages #5610
Bug 1792693: add withStartGuide to dev-console pages #5610
Conversation
@christianvogt: This pull request references Bugzilla bug 1792693, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@christianvogt: This pull request references Bugzilla bug 1792693, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@christianvogt: This pull request references Bugzilla bug 1792693, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
/hold |
/hold |
/hold cancel fixed the pages to add @rohitkrai03 can you take another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@christianvogt: This pull request references Bugzilla bug 1792693, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@christianvogt looks like broken unit tests /lgtm cancel |
Must have missed that file when I fixed up the other tests. The test simply needed to reference the inner component because of shallow rendering. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, christianvogt, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@christianvogt: All pull requests linked via external trackers have merged: openshift/console#5610. Bugzilla bug 1792693 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-2773
Analysis / Root cause:
Some pages were not wrapped with the HOC
withStartGuide
Solution Description:
Added
withStartGuide
to monitoring, pipeline, and helm release pages.Screen shots / Gifs for design review:
Admin console Pipelines:
note the location difference of the tech preview badges. Raising a new issue for this.
Dev-console Pipelines:
Dev-console Helm Releases:
Dev-console Monitoring:
@openshift/team-devconsole-ux
Test setup:
Login with a user who has no projects.
Browser conformance: