Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Browser: Fix sort in example query #5759

Merged

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Jun 17, 2020

For the admin perspective, fix the the example query so that its
sort_desc correctly sorts the results by value.

FYI @cshinn

For the admin perspective, fix the the example query so that its
`sort_desc` correctly sorts the results by value.
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jun 17, 2020
@openshift-ci-robot openshift-ci-robot added component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 17, 2020
@s-urbaniak
Copy link
Contributor

lgtm 👍

@s-urbaniak
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 138b518 into openshift:master Jun 24, 2020
@kyoto kyoto deleted the query-browser-example-query-sort branch June 24, 2020 13:19
@spadgett spadgett added this to the v4.6 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants