Bug 1847480: VM's boot order modal will not remove non-bootable disks #5760
Conversation
Saving changes on VM's boot-order modal will not remove non-bootable disks Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>
openshift-ci-robot
added
the
bugzilla/severity-high
|
@irosenzw: This pull request references Bugzilla bug 1847480, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irosenzw, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
@irosenzw: All pull requests linked via external trackers have merged: openshift/console#5760. Bugzilla bug 1847480 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.5 |
|
@irosenzw: new pull request created: #5762 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -55,6 +53,52 @@ export const getVolumes = (vm: VMKind, defaultValue: V1Volume[] = []): V1Volume[ | |||
| export const getDataVolumeTemplates = (vm: VMKind, defaultValue = []) => | |||
| _.get(vm, 'spec.dataVolumeTemplates') == null ? defaultValue : vm.spec.dataVolumeTemplates; | |||
|
|
|||
| export const getConfigMapVolumes = (vm: VMKind, defaultValue: V1Volume[] = []): V1Volume[] => | |||
| getVolumes(vm, defaultValue).filter((vol) => Object.keys(vol).includes('configMap')); | |||
There was a problem hiding this comment.
why do we have so many copy pasted functions? Can't we just do one and filter it by VolumeType?
| ...getServiceAccountDisks(vm, defaultValue), | ||
| ]; | ||
|
|
||
| export const getBootableDisks = (vm: VMKind, defaultValue: V1Disk[] = []): V1Disk[] => |
There was a problem hiding this comment.
Can't we just do a volume lookup and not calling getEnvDisks for each Disk every time?
Then we can just compare the VolumeType. No need for so many functions.
| (disk) => !getEnvDisks(vm).find((envDisk) => envDisk.name === disk.name), | ||
| ); | ||
|
|
||
| export const getNonBootableDisks = (vm: VMKind, defaultValue: V1Disk[] = []): V1Disk[] => |
There was a problem hiding this comment.
is this function even used somewhere?
Saving changes on VM's boot-order modal will not remove non-bootable disks
Signed-off-by: Ido Rosenzwig irosenzw@redhat.com