[release-4.5.z] Bug 1847971: VM's boot order modal will not remove non-bootable disks #5762

openshift-cherrypick-robot · 2020-06-17T13:14:59Z

This is an automated cherry-pick of #5760

/assign irosenzw

Saving changes on VM's boot-order modal will not remove non-bootable disks Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>

openshift-ci-robot · 2020-06-17T13:15:10Z

@openshift-cherrypick-robot: Bugzilla bug 1847480 has been cloned as Bugzilla bug 1847971. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1847971: VM's boot order modal will not remove non-bootable disks

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-06-17T13:15:35Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1847971, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1847480 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Bugzilla bug 1847480 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yaacov · 2020-06-17T13:21:00Z

/lgtm

openshift-ci-robot · 2020-06-17T13:21:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yaacov · 2020-06-17T13:24:34Z

/rename [release-4.5.z] Bug 1847971: VM's boot order modal will not remove non-bootable disks

yaacov · 2020-06-17T13:25:16Z

/bugzilla refresh

openshift-ci-robot · 2020-06-17T13:25:20Z

@yaacov: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yaacov · 2020-06-17T13:32:06Z

/retitle [release-4.5.z] Bug 1847971: VM's boot order modal will not remove non-bootable disks

irosenzw · 2020-06-17T13:36:55Z

/bugzilla refresh

openshift-ci-robot · 2020-06-17T13:36:58Z

@irosenzw: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-18T01:00:25Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-18T01:00:29Z

@openshift-bot: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-19T01:00:37Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-19T01:00:39Z

@openshift-bot: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-20T01:08:39Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-bot · 2020-06-27T01:01:15Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-27T01:01:18Z

@openshift-bot: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-28T01:00:59Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-28T01:01:02Z

@openshift-bot: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-29T01:01:07Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-29T01:01:09Z

@openshift-bot: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-30T01:01:01Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-30T01:01:05Z

@openshift-bot: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-07-01T01:00:29Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-07-01T01:00:32Z

@openshift-bot: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-07-02T01:00:48Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-07-02T01:00:50Z

@openshift-bot: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-07-03T01:01:10Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-07-03T01:01:12Z

@openshift-bot: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-07-04T01:01:02Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-07-04T01:01:05Z

@openshift-bot: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-07-05T01:01:01Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-07-05T01:01:03Z

@openshift-bot: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-07-06T01:01:02Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-07-06T01:01:05Z

@openshift-bot: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-07-07T01:01:04Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-07-07T01:01:06Z

@openshift-bot: This pull request references Bugzilla bug 1847971, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yaacov · 2020-07-15T12:18:55Z

/bugzilla refresh

openshift-ci-robot · 2020-07-15T12:18:59Z

@yaacov: This pull request references Bugzilla bug 1847971, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.z) matches configured target release for branch (4.5.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1847480 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1847480 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-07-15T21:29:00Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/console#5762. Bugzilla bug 1847971 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bug 1847480: Fix VM's boot order modal

403c0ec

Saving changes on VM's boot-order modal will not remove non-bootable disks Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>

openshift-ci-robot assigned irosenzw Jun 17, 2020

openshift-cherrypick-robot mentioned this pull request Jun 17, 2020

Bug 1847480: VM's boot order modal will not remove non-bootable disks #5760

Merged

openshift-ci-robot requested review from mareklibra and rhrazdil June 17, 2020 13:15

openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Jun 17, 2020

openshift-ci-robot changed the title ~~[release-4.5] Bug 1847480: VM's boot order modal will not remove non-bootable disks~~ [release-4.5] Bug 1847971: VM's boot order modal will not remove non-bootable disks Jun 17, 2020

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 17, 2020

openshift-ci-robot assigned yaacov Jun 17, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2020

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 17, 2020

openshift-ci-robot changed the title ~~[release-4.5] Bug 1847971: VM's boot order modal will not remove non-bootable disks~~ [release-4.5.z] Bug 1847971: VM's boot order modal will not remove non-bootable disks Jun 17, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 15, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 15, 2020

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 15, 2020

openshift-merge-robot merged commit 5b87501 into openshift:release-4.5 Jul 15, 2020

spadgett added this to the v4.5.z milestone Jul 16, 2020

[release-4.5.z] Bug 1847971: VM's boot order modal will not remove non-bootable disks #5762

[release-4.5.z] Bug 1847971: VM's boot order modal will not remove non-bootable disks #5762

Conversation

openshift-cherrypick-robot commented Jun 17, 2020

openshift-ci-robot commented Jun 17, 2020

openshift-ci-robot commented Jun 17, 2020

yaacov commented Jun 17, 2020

openshift-ci-robot commented Jun 17, 2020

yaacov commented Jun 17, 2020

yaacov commented Jun 17, 2020

openshift-ci-robot commented Jun 17, 2020

yaacov commented Jun 17, 2020

irosenzw commented Jun 17, 2020

openshift-ci-robot commented Jun 17, 2020

openshift-bot commented Jun 18, 2020

openshift-ci-robot commented Jun 18, 2020

openshift-bot commented Jun 19, 2020

openshift-ci-robot commented Jun 19, 2020

openshift-bot commented Jun 20, 2020

openshift-bot commented Jun 27, 2020

openshift-ci-robot commented Jun 27, 2020

openshift-bot commented Jun 28, 2020

openshift-ci-robot commented Jun 28, 2020

openshift-bot commented Jun 29, 2020

openshift-ci-robot commented Jun 29, 2020

openshift-bot commented Jun 30, 2020

openshift-ci-robot commented Jun 30, 2020

openshift-bot commented Jul 1, 2020

openshift-ci-robot commented Jul 1, 2020

openshift-bot commented Jul 2, 2020

openshift-ci-robot commented Jul 2, 2020

openshift-bot commented Jul 3, 2020

openshift-ci-robot commented Jul 3, 2020

openshift-bot commented Jul 4, 2020

openshift-ci-robot commented Jul 4, 2020

openshift-bot commented Jul 5, 2020

openshift-ci-robot commented Jul 5, 2020

openshift-bot commented Jul 6, 2020

openshift-ci-robot commented Jul 6, 2020

openshift-bot commented Jul 7, 2020

openshift-ci-robot commented Jul 7, 2020

yaacov commented Jul 15, 2020

openshift-ci-robot commented Jul 15, 2020

openshift-ci-robot commented Jul 15, 2020