New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PVC CDI Image Upload #5765
PVC CDI Image Upload #5765
Conversation
acf946e
to
ccda452
Compare
f0db851
to
299e0fb
Compare
299e0fb
to
f3888b5
Compare
f3888b5
to
abeed56
Compare
e353a83
to
27ed3b8
Compare
27ed3b8
to
14e57b6
Compare
398086a
to
4fd8a1c
Compare
/test frontend |
ea9c105
to
9d53e60
Compare
|
32c4b2d
to
3604fd7
Compare
|
||
const resource: WatchK8sResource = { | ||
kind: CDIConfigModel.kind, | ||
isList: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rawagner I'm not sure why, but with isList
I'm getting the route succesfully 100% of the time.
without it, there are scenarios where the route is empty, not sure why..maybe 1 out of 4 tries its empty
76e7918
to
98ebabe
Compare
/retest |
setError(''); | ||
setIsAllocating(true); | ||
setIsSubmitting(true); | ||
// eslint-disable-next-line promise/catch-or-return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint wont complain if you use .then(...).catch(..)
); | ||
}; | ||
|
||
export const UploadPVC = (props) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont really see a need for this component, just move the params
logic to UploadPVCPage
namespace: string; | ||
fileName?: string; | ||
progress?: number; | ||
uploadStatus?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uploadStatus?: string; | |
uploadStatus?: UPLOAD_STATUS; |
return { | ||
title: `Upload Error`, | ||
body: error?.message, | ||
icon: <ErrorCircleOIcon className="co-icon-and-text__icon" color="#cf1010" />, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to use PF tokens, look at https://github.com/openshift/console/blob/master/frontend/packages/console-shared/src/components/status/icons.tsx#L14
/approve |
98ebabe
to
7bd0b85
Compare
After investigating the Cancel button not firing inside the Status popover, it is found to be a Patternfly bug patternfly/patternfly-react#4577 Therefore, this PR is complete and can be merged @rawagner :) |
replaced |
7bd0b85
to
c808c7b
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glekner, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
PVC Form - Ongoing
VM Wizard - TBD