New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label resources owned by operators #5784
Label resources owned by operators #5784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore that, lol, wrong PR
d199b6b
to
c0fc9b1
Compare
ed156f8
to
e3d2cef
Compare
313ab54
to
4a31e2c
Compare
The review wasn't intentionally left on this PR.
I addressed most of the PR feedback (except for one open question) and removed the lateral label in a separate commit in case I need to roll it back. |
b63a273
to
c48b095
Compare
c48b095
to
30b2ee7
Compare
30b2ee7
to
b3f7bf7
Compare
/kind feature |
b3f7bf7
to
50a8269
Compare
37e2825
to
5507883
Compare
5507883
to
5fcda49
Compare
Addressed PR feedback. |
/retest |
Added logic for detecting a match between operators and owners, and then displaying a label if there's a match. Fixes https://issues.redhat.com/browse/CONSOLE-2288.
1dd3a25
to
715cf41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added web socket for keeping track of CSVs and resource label described in design document. I moved some logic in the ResourceLink component so that URLs are consistently generated for the owner of a given resource. Per @tlwu2013, the Owner link should match the label link. The link in the Owner section of the details page (if present) will now always have a link that matches the label. This should also affect anything using the OwnerReferences component (list views, etc.).
Desktop:
Mobile:
Fixes https://issues.redhat.com/browse/CONSOLE-2288.
Heads up @itsptk and @openshift/team-ux-review.