New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Attached devices flag to ceph plugin #6069
Add Attached devices flag to ceph plugin #6069
Conversation
afreen23
commented
Jul 22, 2020
•
edited
edited
- The flag name is OCS_ATTACHED_DEVICES
- The flag will allow to detect ocs installation on baremetal
- The flag will be consumed for disk replacement kebab action in 4.6
- Updated Readme
- https://issues.redhat.com/browse/RHSTOR-1196
/hold need engg discussions |
130d3f5
to
62f9193
Compare
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest Please review the full test history for this PR and help us cut down flakes. |
requestData.spec.monDataDirHostPath = '/var/lib/rook'; | ||
requestData.spec.storageDeviceSets[0].portable = false; | ||
requestData.metadata = { | ||
...requestData.metadata, | ||
annotations: { | ||
[PLATFORM_ANNOTATION]: 'true', | ||
}, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We should these as args of the request data generator function. No point in having a function if we have to modify again and again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not do refactors for this PR. Just using an existing functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not relevant to this PR, but I think we should make the request function generic.
Post the install PR or in the install PR itself it can be considered. @gnehapk ^^
@@ -15,3 +15,4 @@ export const OCS_INTERNAL_CR_NAME = 'ocs-storagecluster'; | |||
export const NO_PROVISIONER = 'kubernetes.io/no-provisioner'; | |||
export const OCS_SUPPORT_ANNOTATION = 'features.ocs.openshift.io/enabled'; | |||
export const OCS_DEVICE_SET_REPLICA = 3; | |||
export const PLATFORM_ANNOTATION = 'cluster.ocs.openshift.io/local-devices'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const PLATFORM_ANNOTATION = 'cluster.ocs.openshift.io/local-devices'; | |
export const ATTACH_DEVICE_ANNOTATION = 'cluster.ocs.openshift.io/local-devices'; |
Need to update README |
62f9193
to
7dc8906
Compare
- The flag name is OCS_ATTACHED_DEVICES - Its enabled on the annotation: cluster.ocs.openshift.io/local-devices - The flag will allow to detect ocs installation on baremetal - The flag will be consumed for disk replacement kebab action in 4.6 - Updates readme - https://issues.redhat.com/browse/RHSTOR-1196 Signed-off-by: Afreen Rahman <afrahman@redhat.com>
7dc8906
to
a415b82
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, cloudbehl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |