New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1870469: Check for podName before displaying Task logs #6208
Conversation
/kind bug |
/retest |
@@ -138,7 +138,7 @@ class PipelineRunLogs extends React.Component<PipelineRunLogsProps, PipelineRunL | |||
)} | |||
</div> | |||
<div className="odc-pipeline-run-logs__container"> | |||
{activeItem ? ( | |||
{activeItem && resources[0].name ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking for the name here seems a bit odd, a better approach would be to create the resources only when a pod exists.
const podName = taskRunFromYaml[activeItem]?.status?.podName;
const resources = taskCount > 0 && podName && [
{
name: podName,
kind: 'Pod',
namespace: obj.metadata.namespace,
prop: `obj`,
isList: false,
},
];
{activeItem && resources[0].name ? ( | |
{activeItem && resources ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Checking during resource creation is definitely better. I've updated with your suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyanshiGupta, rohitkrai03, rottencandy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@rottencandy: This pull request references Bugzilla bug 1870469, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rottencandy: All pull requests linked via external trackers have merged: openshift/console#6208. Bugzilla bug 1870469 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-4273
Analysis / Root cause:
When checking logs for a failed PipelineRun that has not run any pods, a random pod log will be shown from any running pod.
Solution Description:
Ensure that
podName
is not empty in the pipelinerun spec before trying to display logs.Browser conformance: