New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1872288: Delete the hashed session token on user logout #6445
Bug 1872288: Delete the hashed session token on user logout #6445
Conversation
@jhadvig: This pull request references Bugzilla bug 1872288, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla cc-qa |
@jhadvig: This pull request references Bugzilla bug 1872288, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Does this need to wait for openshift/origin#25415? |
QE tested the fix with steps:
The oauthaccesstoken is deleted after user is logged out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, spadgett, yapei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It looks like #25145 make the token a different format as in 4.6. But the console fix of deleting access token should not rely on that. Just my understanding, will wait for double confirmation |
@yapei check the enhancement describing the change: https://github.com/openshift/enhancements/blob/master/enhancements/authentication/oauth-resource-storage.md |
we need to wait for openshift/origin#25415 to get merged /hold |
No, the other way around. /hold cancel |
@jhadvig: All pull requests linked via external trackers have merged: Bugzilla bug 1872288 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@yapei @jhadvig @sttts I think this PR verification requires openshift/origin#25415. |
Manual backport of #6431
/assign @spadgett
cc'ing @sttts