Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1873037: Show inline alert message "Waiting for build" only if there is a BuildConfig #6458

Merged
merged 1 commit into from Sep 2, 2020

Conversation

jerolimov
Copy link
Member

Fixes:
https://issues.redhat.com/browse/ODC-4468
https://bugzilla.redhat.com/show_bug.cgi?id=1873037

Analysis / Root cause:
When importing a Deployment from a Container the invalid message "Waiting for the build" was displayed. This message was introduced in ODC-3875 / #6155, but should only be displayed when a BuildConfig is available.

Solution Description:
Only the parent component knows if there are also BuildConfigs for the selected Deployment. Added a new prop to the PodOverview which is required to show the alert message.

Screen shots / Gifs for design review:
Git Import before:
image-deployment-before

Git Import after (unchanged!):
git-deployment-after

Image container import before:
image-deployment-before

Image container import after (Alert message was not shown anymore):
image-deployment-after3

The two pods here are tracked in ODC-3175 and fixed in #6138.

Unit test coverage report:
Unchanged

Test setup:

  • Create a Deployment from a Git repository and from a container image.
  • Check the sidebar areas Pods and Builds in the Topology of the new Deployment while the Build is running and finished.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 27, 2020
@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Bugzilla bug 1873037, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1873037: Show inline alert message "Waiting for build" only if there is a BuildConfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Aug 27, 2020
@jerolimov
Copy link
Member Author

/retest

1 similar comment
@jerolimov
Copy link
Member Author

/retest

@jerolimov
Copy link
Member Author

/retest
/assign rohitkrai03

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@jerolimov
Copy link
Member Author

Just rebased on master and solve merge conflict

Copy link
Contributor

@rottencandy rottencandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, rohitkrai03, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit 13efa0e into openshift:master Sep 2, 2020
@openshift-ci-robot
Copy link
Contributor

@jerolimov: All pull requests linked via external trackers have merged:

Bugzilla bug 1873037 has been moved to the MODIFIED state.

In response to this:

Bug 1873037: Show inline alert message "Waiting for build" only if there is a BuildConfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 11, 2020
@jerolimov jerolimov deleted the odc-4468 branch August 7, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants