New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1873037: Show inline alert message "Waiting for build" only if there is a BuildConfig #6458
Conversation
@jerolimov: This pull request references Bugzilla bug 1873037, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
1 similar comment
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Just rebased on master and solve merge conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, rohitkrai03, rottencandy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jerolimov: All pull requests linked via external trackers have merged: Bugzilla bug 1873037 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-4468
https://bugzilla.redhat.com/show_bug.cgi?id=1873037
Analysis / Root cause:
When importing a Deployment from a Container the invalid message "Waiting for the build" was displayed. This message was introduced in ODC-3875 / #6155, but should only be displayed when a
BuildConfig
is available.Solution Description:
Only the parent component knows if there are also BuildConfigs for the selected Deployment. Added a new prop to the PodOverview which is required to show the alert message.
Screen shots / Gifs for design review:
Git Import before:
Git Import after (unchanged!):
Image container import before:
Image container import after (Alert message was not shown anymore):
The two pods here are tracked in ODC-3175 and fixed in #6138.
Unit test coverage report:
Unchanged
Test setup:
Deployment
from a Git repository and from a container image.Pods
andBuilds
in the Topology of the new Deployment while the Build is running and finished.Browser conformance: