New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1862564: Fix column visibility on various screen sizes #6562
Bug 1862564: Fix column visibility on various screen sizes #6562
Conversation
@jcaianirh: This pull request references Bugzilla bug 1862564, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jcaianirh: This pull request references Bugzilla bug 1862564, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@jcaianirh: This pull request references Bugzilla bug 1862564, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcaianirh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcaianirh
9bdd1be
to
c505756
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaianirh, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jcaianirh: All pull requests linked via external trackers have merged: Bugzilla bug 1862564 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1862564
For tables supporting column management (pods, nodes, projects, namespaces), remove static column visibility classes, and add a common table function to dynamically enable/disable visibility as follows:
0 - (SM = 576) = 2 columns max
SM - (MD = 768) = 4 columns max
MD - (LG = 992) = 4 columns max
LG - (XL = 1200) = 6 columns max
XL - (XXL = 1400) = 8 columns max
XXL - infinity = 9 columns max
Above sizes are based on PF breakpoints.
SM - LG have the same max col values since that is the breakpoint that the nav shows/hides. Column priority is left to right.
Before example of pods page with 9 columns selected at 1100 pixels:
After example of same table config and pixel width: