New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1883342: [Release 4.5] Convert Pipeline StartedBy Label to Annotation #6769
Bug 1883342: [Release 4.5] Convert Pipeline StartedBy Label to Annotation #6769
Conversation
@andrewballantyne: This pull request references Bugzilla bug 1883342, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
1a656d5
to
19737f9
Compare
19737f9
to
44bdeb0
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinandan13jan, andrewballantyne, invincibleJai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel This is now sitting on top of the full code that is in master. Should be good for the next available z-stream. |
/bugzilla refresh |
@jerolimov: This pull request references Bugzilla bug 1883342, which is valid. 8 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@andrewballantyne: All pull requests linked via external trackers have merged: Bugzilla bug 1883342 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual cherry-pick of #6639 and then #6744 to fix an edge case issue with Triggers.
There is an inconsistency in implementation as the lines around this changed because of the work done in the
master
branch for #6615 so it is a prerequisite for this PR and will cause merge conflicts which I'll have to rebase./hold