Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors feature enable code for OCS #6884

Merged
merged 1 commit into from Oct 9, 2020

Conversation

a2batic
Copy link
Contributor

@a2batic a2batic commented Oct 9, 2020

Minor refactors as per comments on #6880

Signed-off-by: Kanika Murarka <kmurarka@redhat.com>
@openshift-ci-robot openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Oct 9, 2020
@a2batic a2batic changed the title Refactors feature enable code Refactors feature enable code for OCS Oct 9, 2020
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit 0de5675 into openshift:master Oct 9, 2020
@spadgett spadgett added this to the v4.7 milestone Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants