New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2439: i18n common components: list view/details components #6888
CONSOLE-2439: i18n common components: list view/details components #6888
Conversation
8be8853
to
f821eb0
Compare
@rebeccaalpert: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
f821eb0
to
8c59420
Compare
Adding a hold label because this will need to merge after the first IBM PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rebeccaalpert
Addressed PR feedback; let me know if you have other comments! |
97a0c7d
to
107ad18
Compare
107ad18
to
5814930
Compare
35af3f8
to
b4bd8c1
Compare
b4bd8c1
to
2462692
Compare
/label docs-approved |
@rebeccaalpert There is still no "Operators" nav menu, so code about OLM in the pr could not be tested from console, correct me if I understand wrong. |
Hey @yanpzhan - Correct, there's no Operators nav menu. If you want to get around it and test those pages, you can turn pseudolocalization off, navigate to that section, and then turn pseudolocalization back on. To do that, just remove the query parameter, do a hard refresh, and then add the query parameter again when you're in the right place. |
6d0aead
to
f63b8a2
Compare
Rebased so I lost the lgtm. |
|
f63b8a2
to
2c6005f
Compare
|
/retest |
/label qe-approved |
Handled listpage component, filter toolbar, details page breadcrumbs, resourcesummary/detailsitem, common details page headings, managed by operator link, and conditions table
2c6005f
to
1c9b925
Compare
Rebased again. |
/label px-approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Handled list page component, filter toolbar, details page breadcrumbs, resource summary/details item, common details page headings, managed by operator link, and the conditions table.
I'm handling shared tabs (environment, YAML, etc.) in separate PRs.
This PR excludes action menus and kebabs since I'm still debugging a dropdown-related TypeScript issue.
CONSOLE-2439