Bug 1891552: Handle missing labels as empty

[srueg]

To implement the same logic as in AlertManager which handles missing
labels as the empty label [1].

[1] https://github.com/prometheus/alertmanager/blob/a8ed0d58509d0251adcb159552b9ab098e206f1f/types/match.go#L72

Solves https://access.redhat.com/support/cases/#/case/02776669

[openshift-ci-robot]

Hi @srueg. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

/assign @kyoto
/ok-to-test

[kyoto]

Thank you for the PR @srueg!

@simonpasquier Helped me confirm the issue and the code change looks good to me.

I'd like to do some more testing first, then hopefully we can merge.

[kyoto]

/lgtm

Tested locally and compared with Alertmanager behavior. Thanks again @srueg!

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, srueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [kyoto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[srueg]

Cool, thanks for the quick handling!
What's the process for releasing this? Can we get this back-ported to v4.5 ?

[germanparente]

I have just reported:
https://bugzilla.redhat.com/show_bug.cgi?id=1891552
Bug 1891552 - Handle missing labels as empty.

to include this fix downstream.

[kyoto]

/cherrypick release-4.6

[openshift-cherrypick-robot]

@kyoto: new pull request created: #7002

Details

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@srueg: All pull requests linked via external trackers have merged:

Bugzilla bug 1891552 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.6] Bug 1891552: Handle missing labels as empty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kyoto]

/retitle Bug 1891552: Handle missing labels as empty