Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1890467: Fix edit app flow in case service not available #6952

Merged

Conversation

divyanshiGupta
Copy link
Contributor

@divyanshiGupta divyanshiGupta commented Oct 19, 2020

Jira: https://issues.redhat.com/browse/ODC-5016

This PR adds the fix for not creating an update service request when service is not available and keeping the route unchecked if no route is available.

Peek 2020-10-19 18-48

/kind bug

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. component/dev-console Related to dev-console labels Oct 19, 2020
@divyanshiGupta divyanshiGupta force-pushed the jira-issue#5016 branch 2 times, most recently from 36de2b4 to 1d1ef17 Compare October 19, 2020 15:18
@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, divyanshiGupta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5c991c4 into openshift:master Oct 21, 2020
@divyanshiGupta
Copy link
Contributor Author

/cherrypick release-4.6

@openshift-cherrypick-robot

@divyanshiGupta: new pull request created: #6978

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@divyanshiGupta divyanshiGupta changed the title Fix edit app flow in case service not available Bug 1890467: Fix edit app flow in case service not available Oct 22, 2020
@openshift-ci-robot
Copy link
Contributor

@divyanshiGupta: All pull requests linked via external trackers have merged:

Bugzilla bug 1890467 has been moved to the MODIFIED state.

In response to this:

Bug 1890467: Fix edit app flow in case service not available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants