New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2393: i18n user management page #7098
CONSOLE-2393: i18n user management page #7098
Conversation
Hi @wansc2016. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8f7526a
to
728de80
Compare
5d8cde5
to
97666fc
Compare
97666fc
to
e900cb8
Compare
717093a
to
e2588d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
I apologize for not reviewing sooner. I had the comments finished, but forgot to submit the review. Please feel free to reach out if you need a code review. Thanks.
Looks good overall. We are switching to use these conventions for capitalization as we externalize the strings: http://openshift.github.io/openshift-origin-design/conventions/documentation/capitalization.html
@@ -64,12 +66,12 @@ export const flatten = (resources) => | |||
return ret; | |||
}); | |||
|
|||
const menuActions = ({ subjectIndex, subjects }, startImpersonate) => { | |||
const menuActions = ({ subjectIndex, subjects }, startImpersonate_) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you needed to add the underscore to startImpersonate
? We've been trying to avoid trailing underscores where possible in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I will revoke it back.
/ok-to-test |
@spadgett Should we change Role Binding to RoleBinding in all places? Will it be inconsistent with Navigation Menu? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except it looks like we have a test failure on the role bindings page. This is ready for testing and approvals, however.
/assign @yapei @ahardin-rh @reestr
|
||
const bindingKinds = [ | ||
{ | ||
value: 'RoleBinding', | ||
title: 'Namespace Role Binding (RoleBinding)', | ||
desc: 'Grant the permissions to a user or set of users within the selected namespace.', | ||
title: i18next.t('bindings~Namespace RoleBinding (RoleBinding)'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Here and below I would use "role binding" since it's not exactly a k8s kind in this case. (The kind appears beside in parentheses.)
title: i18next.t('bindings~Namespace RoleBinding (RoleBinding)'), | |
title: i18next.t('bindings~Namespace role binding (RoleBinding)'), |
title: 'Cluster-wide Role Binding (ClusterRoleBinding)', | ||
desc: | ||
'Grant the permissions to a user or set of users at the cluster level and in all namespaces.', | ||
title: i18next.t('bindings~Cluster-wide RoleBinding (ClusterRoleBinding)'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: i18next.t('bindings~Cluster-wide RoleBinding (ClusterRoleBinding)'), | |
title: i18next.t('bindings~Cluster-wide role binding (ClusterRoleBinding)'), |
Reported a bug about the pr: https://bugzilla.redhat.com/show_bug.cgi?id=1915723 |
255fae4
to
26fabf3
Compare
01e56c0
to
997a612
Compare
@yanpzhan https://bugzilla.redhat.com/show_bug.cgi?id=1915723 has been fixed. "Add more" issue will be fixed with https://issues.redhat.com/browse/CONSOLE-2474 |
@wansc2016: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label qe-approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for docs approval
@ahardin-rh PTAL, thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, wansc2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label docs-approved |
/hold cancel |
Thanks @wansc2016 for helping us with this! |
The PR includes i18n support for the following pages:
User management
CONSOLE-2393