New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ArgoCD dashboard link to GitOpsListPage #7127
Add ArgoCD dashboard link to GitOpsListPage #7127
Conversation
Hi @reginapizza. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reginapizza Please add prettier extension to your code editor and format the code. Also add eslint extension if you haven't already to visualize lint errors in the editor itself. I see your tab size is also not correct please change it to 2.
frontend/packages/dev-console/src/components/gitops/GitOpsListPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/GitOpsListPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/GitOpsListPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/GitOpsListPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/GitOpsListPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/GitOpsListPage.scss
Outdated
Show resolved
Hide resolved
{aLink ? ( | ||
<Split className="odc-gitops-list-page-heading"> | ||
<ExternalLink href={aLink.spec.href} text="Argo CD" additionalClassName="odc-gitops-list-page-heading__argocd"/> | ||
<DevPreviewBadge /> | ||
</Split> | ||
) : ( | ||
<DevPreviewBadge /> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{aLink ? ( | |
<Split className="odc-gitops-list-page-heading"> | |
<ExternalLink href={aLink.spec.href} text="Argo CD" additionalClassName="odc-gitops-list-page-heading__argocd"/> | |
<DevPreviewBadge /> | |
</Split> | |
) : ( | |
<DevPreviewBadge /> | |
)} | |
<Split className="odc-gitops-list-page-heading"> | |
{argocdLink && <SplitItem><ExternalLink href={aLink.spec.href} text="Argo CD" additionalClassName="odc-gitops-list-page-heading__argocd"/></SplitItem>} | |
<SplitItem><DevPreviewBadge /></SplitItem> | |
</Split> |
frontend/packages/dev-console/src/components/gitops/GitOpsListPage.scss
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/GitOpsListPage.scss
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/GitOpsListPage.tsx
Outdated
Show resolved
Hide resolved
.odc-gitops-list-page-heading { | ||
align-items: center; | ||
font-size: 12px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new line at the end of the file
@reginapizza code looks good to me. I will add lgtm after @lwrigh approves this PR. |
@reginapizza Can you add a screenshot of what the Application Details/Application Environments page looks like now with the ArgoCD link in the stage columns? |
@lwrigh the details page change will actually be in a separate PR, this is only for the list page just so we could get in the changes faster. The details page PR will be created today and I will add the pictures from it, hope this explanation helps. Let me know if you still want it here though! |
@reginapizza That sounds good to me! Feel free to tag me on the separate PR. This one looks good to me then! |
/lgtm |
/assign @rohitkrai03 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyanshiGupta, reginapizza, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
This PR is to add a link to the Argo CD dashboard on the GitOpsListPage (see image below).
Things to note:
argocd
then the link will not appear