New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add error status popover in the pipleline, pipelinerun and taskrun list #7160
add error status popover in the pipleline, pipelinerun and taskrun list #7160
Conversation
The arrow of the popover should align with whatever the user clicks, so in this case it should be lined up with failed |
/retest |
0d30238
to
49f9418
Compare
@bgliwa01 Aligned the popover with the status. Updated the code and screenshots. |
@@ -46,7 +46,7 @@ export const PipelineRunDetails: React.FC<PipelineRunDetailsProps> = ({ obj: pip | |||
</dl> | |||
<RunDetailsErrorLog | |||
logDetails={getPLRLogSnippet(pipelineRun)} | |||
namespace={pipelineRun.metadata.name} | |||
namespace={pipelineRun.metadata.namespace} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 👍
import { PipelineRunModel } from '../../../models'; | ||
import PipelineResourceStatus from './PipelineResourceStatus'; | ||
import StatusPopoverContent from './StatusPopoverContent'; | ||
import { DASH } from '@console/shared'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Move absolute import above relative
.odc-statuspopover-content { | ||
min-height: 175px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understand that the content could not have a full dynamic high because of the left-arrow, but here is an recommendation that we could grow the code snippet to the available space. What do you think?
With the following flex layout:
.odc-statuspopover-content { | |
min-height: 175px; | |
} | |
.odc-statuspopover-content { | |
min-height: 175px; | |
display: flex; | |
flex-direction: column; | |
pre { | |
flex-grow: 1; | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally and works fine.
Add a small UI improvement idea, if you like it we can go with it, otherwise this lgtm.
aa4ef52
to
58c450c
Compare
Thanks @jerolimov, definitely it looks much better now :) I have made the suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, tested it locally, works fine
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
/retest Please review the full test history for this PR and help us cut down flakes. |
New pipeline-plugin package was established, we'll need you to cherry pick this over onto that. Hopefully it is straight forward as the directory structure should be relatively unchanged. |
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold It tested all last night, which is a waste of resources. Unhold after the rebase. |
58c450c
to
aaaf4ba
Compare
Rebased the PR |
/retest |
2 similar comments
/retest |
/retest |
Checks are still failing, putting on hold for now. Will remove it after sometime. |
aaaf4ba
to
65fe282
Compare
Moved all the newly created files to the new pipelines-plugin package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still works fine 👍
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgliwa01, jerolimov, karthikjeeyar, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Fixes:
https://issues.redhat.com/browse/ODC-5061
https://issues.redhat.com/browse/ODC-5099
Analysis:
always)
Solution Description:
Screen shots / Gifs for design review:
Failed status field to have popover:
Log snippet in PLR details page
Correct Task name in the taskRun list Component
Unit test coverage report:
Test setup:
Browser conformance:
@andrewballantyne @bgliwa01 @openshift/team-devconsole-ux