-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1872166: Fix Silences link redirection from developer perspective #7248
Conversation
@vikram-raj: This pull request references Bugzilla bug 1872166, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug |
/cc @kyoto |
Before proceeding with this, I'd like to confirm with @cshinn that we really want to add the silence details page and edit form to the dev console? If they're not needed, this bug fix would simply be a case of modifying the breadcrumbs link URL. |
@kyoto thanks for pointing this out. I think I misunderstood the initial bug that @pneedle-rh filed. I think the best thing to do here is just to take users to the alerts list once the "silence" button is pressed. Sorry the response took a while, I've been out of the office for the past several days |
3fe0392
to
45ae8b4
Compare
@kyoto I updated the PR. Now I update the breadcrumbs link as per perspective. PTAL. |
? `/dev-monitoring/ns/${namespace}/silences` | ||
: '/monitoring/silences', | ||
path: | ||
activePerspective === 'dev' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also change the link text to Alerts
for the dev perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the text to Alerts
for the dev perspective.
@vikram-raj: This pull request references Bugzilla bug 1872166, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm Thanks @vikram-raj |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vikram-raj: All pull requests linked via external trackers have merged: Bugzilla bug 1872166 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-4901
Analysis / Root cause:
In the Developer perspective, a Silences link redirects to an unexpected 'Alerts' page after creating a silence.
The page that is shown includes Alerts, Silences, and Alerting Rules tabs, which I believe should only be accessible from the Administrator's perspective.
Solution Description:
Users are taken back to the alerts list from the silence details page where they can see that the alert has been silenced.
Screen shots / Gifs for design review:
Unit test coverage report:
Browser conformance: