Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress: test for existance of 'cypress-a11y-report.json' before running 'yarn cypress-a11y-report' #7262

Conversation

dtaylor113
Copy link
Contributor

This PR unblocks OLM queue!

It appears that our a11y reporting doesn't scale. A cypress-a11y-report.json is created in each package separately and the a11y script is only looking in packages/integration-tests-cypress. This PR checks for the existance of packages/integration-tests-cypress/cypress-a11y-report.json first before executing yarn cypress-a11y-report -so a11y results will only output for console tests.

A longer term solution is needed to figure out how to merge all the cypress-a11y-report.json files which maybe created in each package dir into a single json file. Should be straight forward as we already do mochawesome-merge for the cypress-unit json files.

@dtaylor113 dtaylor113 changed the title test for existance of 'cypress-a11y-report.json' before running 'yarn cypress-a11y-report' Cypress: test for existance of 'cypress-a11y-report.json' before running 'yarn cypress-a11y-report' Nov 18, 2020
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2020
@dtaylor113
Copy link
Contributor Author

/retest

2 similar comments
@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit e90077d into openshift:master Nov 19, 2020
@dtaylor113 dtaylor113 deleted the disable-cypress-a11y-reporting branch November 25, 2020 14:21
@spadgett spadgett added this to the v4.7 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants