Skip to content

Bug 1901594: fix item-create unstability#7343

Closed
yapei wants to merge 1 commit into
openshift:masterfrom
yapei:master
Closed

Bug 1901594: fix item-create unstability#7343
yapei wants to merge 1 commit into
openshift:masterfrom
yapei:master

Conversation

@yapei

@yapei yapei commented Nov 27, 2020

Copy link
Copy Markdown
Contributor

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 27, 2020
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@yapei: This pull request references Bugzilla bug 1901594, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1901594: fix item-create unstability

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yapei
To complete the pull request process, please assign vojtechszocs after the PR has been reviewed.
You can assign the PR to them by writing /assign @vojtechszocs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@yapei: This pull request references Bugzilla bug 1901594, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1901594: fix item-create unstability

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yapei

yapei commented Nov 30, 2020

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

1 similar comment
@yapei

yapei commented Dec 1, 2020

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

@spadgett spadgett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason not to use the default timeout?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spadgett Good question, didn't take default timeout into consideration. default timeout should also be ok

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

@yapei: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 1b7afe2 link /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

});
},
clickCreateYAMLbutton: () => {
cy.get(`[data-test="item-create"]`).should('be.visible');

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be cy.byTestID('item-create').should('be.visible');

@dtaylor113

Copy link
Copy Markdown
Contributor

I've been looking into this as well (didn't see the BZ for it till now :-) ) , I'm unsure why it cannot find the Create button at times. I'm suspicious of this recent change to data-test="item-create" for consistency. Did I miss something in this change? I've inspected the pages in question and the Create button does have data-test="item-create" so still not sure what is causing this.

@dtaylor113

Copy link
Copy Markdown
Contributor

/test all

@spadgett

spadgett commented Dec 2, 2020

Copy link
Copy Markdown
Member

Closing in favor of #7365, which should fix the openshift-ocp-installer-console-aws-4.7 job.

/close

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@spadgett: Closed this PR.

Details

In response to this:

Closing in favor of #7365, which should fix the openshift-ocp-installer-console-aws-4.7 job.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@yapei: This pull request references Bugzilla bug 1901594. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1901594: fix item-create unstability

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants