Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1919379: Update dotnet logo for '.NET 5'. #7373

Merged
merged 1 commit into from Jan 22, 2021

Conversation

tmds
Copy link
Contributor

@tmds tmds commented Dec 1, 2020

The open-source .NET platform '.NET Core' has been
rebranded '.NET' for the '.NET 5' release.

This updates the logo used by OpenShift to match that change.

The new logo is downloaded from https://raw.githubusercontent.com/dotnet/brand/master/logo/dotnet-logo.svg.
It is licensed under CC0 1.0 Universal.

cc @yselkowitz @omajid @aslicerh

The open-source .NET platform '.NET Core' has been
rebranded '.NET' for the '.NET 5' release.

This updates the logo used by OpenShift to match that change.

The new logo is downloaded from https://raw.githubusercontent.com/dotnet/brand/master/logo/dotnet-logo.svg.
It is licensed under CC0 1.0 Universal.
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Dec 1, 2020
@openshift-ci-robot
Copy link
Contributor

Hi @tmds. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 1, 2020
@yselkowitz
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2020
@yselkowitz
Copy link
Contributor

/retest

@yselkowitz
Copy link
Contributor

/assign @kyoto

@tmds
Copy link
Contributor Author

tmds commented Dec 8, 2020

@kyoto @yselkowitz is this good to merge?

@tmds
Copy link
Contributor Author

tmds commented Dec 17, 2020

ping @kyoto @yselkowitz

@yselkowitz
Copy link
Contributor

/retest
/assign @bparees

@bparees
Copy link

bparees commented Dec 22, 2020

/unassign
/assign @jhadvig

@yselkowitz
Copy link
Contributor

/test all

@yselkowitz
Copy link
Contributor

/retest

@omajid
Copy link

omajid commented Jan 19, 2021

Hey folks, any ETA on when this PR can be merged? We have been trying to get this merged for 1.5 months now....

@yselkowitz
Copy link
Contributor

Sorry, not much more I can do here. Let's try finding another assignee.
/assign @bparees

@bparees
Copy link

bparees commented Jan 22, 2021

/assign @spadgett

@spadgett
Copy link
Member

/override ci/prow/kubevirt-plugin

We had a bug where the kubevirt-plugin test ran on PRs where they shouldn't have. Overriding the status.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

@spadgett: Overrode contexts on behalf of spadgett: ci/prow/kubevirt-plugin

In response to this:

/override ci/prow/kubevirt-plugin

We had a bug where the kubevirt-plugin test ran on PRs where they shouldn't have. Overriding the status.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, tmds

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2021
@spadgett spadgett changed the title Update dotnet logo for '.NET 5'. Bug 1919379: Update dotnet logo for '.NET 5'. Jan 22, 2021
@spadgett
Copy link
Member

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 22, 2021
@openshift-ci-robot
Copy link
Contributor

@tmds: This pull request references Bugzilla bug 1919379, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1919379: Update dotnet logo for '.NET 5'.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 22, 2021
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1919379, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e64a806 into openshift:master Jan 22, 2021
@openshift-ci-robot
Copy link
Contributor

@tmds: All pull requests linked via external trackers have merged:

Bugzilla bug 1919379 has been moved to the MODIFIED state.

In response to this:

Bug 1919379: Update dotnet logo for '.NET 5'.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants