New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error state for Raw Capacity Card #7415
Fix error state for Raw Capacity Card #7415
Conversation
bipuladh
commented
Dec 4, 2020
•
edited
edited
- Align Error message for capacity breakdown card to the center
af584dc
to
d8ccd2f
Compare
@@ -90,8 +91,8 @@ const RawCapacityCard: React.FC = React.memo(() => { | |||
</div> | |||
</> | |||
)} | |||
{!loadError && loading && <LoadingCardBody />} | |||
{loadError && !loading && <ErrorCardBody />} | |||
{loading && !loadError && <LoadingCardBody />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case of all undefined values can't we just say not available
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case of all undefined
values loadError
will be true
and this block will not run. Line 95 with ErrorCardBody
having Not Available
will get activated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
righto!
/lgtm |
/test analyze |
- Align Error message for capacity breakdown card to the center
d8ccd2f
to
3fca554
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, cloudbehl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |