Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error state for Raw Capacity Card #7415

Merged

Conversation

bipuladh
Copy link
Contributor

@bipuladh bipuladh commented Dec 4, 2020

  • Align Error message for capacity breakdown card to the center
    Screenshot from 2020-12-04 12-56-03

@openshift-ci-robot openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Dec 4, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@@ -90,8 +91,8 @@ const RawCapacityCard: React.FC = React.memo(() => {
</div>
</>
)}
{!loadError && loading && <LoadingCardBody />}
{loadError && !loading && <ErrorCardBody />}
{loading && !loadError && <LoadingCardBody />}
Copy link
Contributor

@cloudbehl cloudbehl Dec 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of all undefined values can't we just say not available?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of all undefined values loadError will be true and this block will not run. Line 95 with ErrorCardBody having Not Available will get activated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

righto!

@cloudbehl
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@cloudbehl
Copy link
Contributor

/test analyze
/test backend

- Align Error message for capacity breakdown card to the center
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@cloudbehl
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, cloudbehl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8592ed2 into openshift:master Dec 4, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants