Fix Installation Tests for Ceph #7639
Conversation
openshift-ci-robot
added
component/ceph
|
/test analyze |
|
We should specify the issue we are fixing in the commit message. |
|
/test analyze |
- Enable labelling of namespace in OLM Page - Click Next to adjust for Configure Page - Support situations where Operators Panel is already open
bipuladh
force-pushed
the
fix_install_tests
branch
from
4e3f2ce
to
0714137
Compare
| @@ -26,6 +26,7 @@ Cypress.Commands.add('install', (mode: 'Internal' | 'Attached' = 'Internal', enc | |||
| cy.log('Subscribe to OCS Operator'); | |||
| cy.byLegacyTestID('operator-install-btn').click({ force: true }); | |||
| cy.byTestID('Operator recommended namespace:-radio-input').should('be.checked'); | |||
| cy.byTestID('enable-monitoring').click(); | |||
There was a problem hiding this comment.
can you put a comment, if yes.
There was a problem hiding this comment.
yes. We need to remove it for 4.7
There was a problem hiding this comment.
it's required all the time, but we can remove it once 4.7 comes.
| afterEach(() => { | ||
| checkErrors(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
To be added once we fix i18n issues.
There was a problem hiding this comment.
can you just comment on the code instead of removing it so we don't miss out?
|
/lgtm |
|
/test analyze |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, cloudbehl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
| @@ -26,6 +26,7 @@ Cypress.Commands.add('install', (mode: 'Internal' | 'Attached' = 'Internal', enc | |||
| cy.log('Subscribe to OCS Operator'); | |||
| cy.byLegacyTestID('operator-install-btn').click({ force: true }); | |||
| cy.byTestID('Operator recommended namespace:-radio-input').should('be.checked'); | |||
| cy.byTestID('enable-monitoring').click(); | |||
| cy.byTestID('install-operator').click(); | |||
| cy.byTestID('success-icon', { timeout: 180000 }).should('be.visible'); | |||
| cy.exec('oc get project openshift-storage -o json').then((res) => { | |||
There was a problem hiding this comment.
Up to this part, we can move to some global integration-tests-cypress folder, So anyone can reuse this installation logic by passing the operator name and namespace as param.
What I am suggesting here is, The operator install flow is a pre-requisite for OCS cluster creation flow. Instead of naming it as "install", we can name it something like prepate_storage_cluster or create_ocs_cluster. And prepare_ocs_cluster flow can the call install flow externally. For easier understanding separate these two install and create logic in different functions. (Or) Add "install" as cypress global namespace from global cypress IT and Add "prepare_ocs_cluster" as cypress global namespace in ceph-storage-plugin cypress IT.
Also, we can test our cluster creation logic independently by passing its own parameters.
/assign @cloudbehl