Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1766287: Fix use of hello-openshift imagestream #7646

Merged
merged 1 commit into from Jan 6, 2021

Conversation

yselkowitz
Copy link
Contributor

The new imagestream was missing a lookupPolicy setting which prevented
it from being a drop-in replacement of the image on Docker Hub. With
that fixed in the Samples operator, only the annotations are needed from
commit eee9a0c.

This is dependent on openshift/cluster-samples-operator#350

/hold
/assign @cyril-ui-developer

The new imagestream was missing a lookupPolicy setting which prevented
it from being a drop-in replacement of the image on Docker Hub.  With
that fixed in the Samples operator, only the annotations are needed from
commit eee9a0c.
@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Dec 23, 2020
@openshift-ci-robot
Copy link
Contributor

@yselkowitz: This pull request references Bugzilla bug 1766287, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1766287: Fix use of hello-openshift imagestream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 23, 2020
@yselkowitz
Copy link
Contributor Author

When testing, the key is to check that hello-openshift is pulled from the payload instead of from docker.io.

@yselkowitz
Copy link
Contributor Author

/hold cancel
/test all

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2020
@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

/unassign
/cc @cyril-ui-developer
/assign @jhadvig

@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

/test all

@cyril-ui-developer
Copy link
Contributor

/retest

@spadgett
Copy link
Member

spadgett commented Jan 4, 2021

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2021
@cyril-ui-developer
Copy link
Contributor

cyril-ui-developer commented Jan 4, 2021

/lgtm

@yselkowitz
Copy link
Contributor Author

/igtm

typo?

@yselkowitz
Copy link
Contributor Author

/retest

3 similar comments
@cyril-ui-developer
Copy link
Contributor

/retest

@cyril-ui-developer
Copy link
Contributor

/retest

@cyril-ui-developer
Copy link
Contributor

/retest

@cyril-ui-developer
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, spadgett, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@yselkowitz
Copy link
Contributor Author

Is there a reason the analyze test keeps failing?

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@yselkowitz
Copy link
Contributor Author

/hold
Could someone please explain the consistent failures in the analyze test?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2021
@pweil-
Copy link
Contributor

pweil- commented Jan 5, 2021

Could someone please explain the consistent failures in the analyze test?

We began seeing this memory issue just before the break and bumped the memory limit but that doesn't appear to have worked. @spadgett opened #7702 yesterday as another solution. Hopefully that does the trick!

@yselkowitz
Copy link
Contributor Author

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2021
@openshift-merge-robot openshift-merge-robot merged commit b3e4c6f into openshift:master Jan 6, 2021
@openshift-ci-robot
Copy link
Contributor

@yselkowitz: All pull requests linked via external trackers have merged:

Bugzilla bug 1766287 has been moved to the MODIFIED state.

In response to this:

Bug 1766287: Fix use of hello-openshift imagestream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants