New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1766287: Fix use of hello-openshift imagestream #7646
Conversation
The new imagestream was missing a lookupPolicy setting which prevented it from being a drop-in replacement of the image on Docker Hub. With that fixed in the Samples operator, only the annotations are needed from commit eee9a0c.
@yselkowitz: This pull request references Bugzilla bug 1766287, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When testing, the key is to check that hello-openshift is pulled from the payload instead of from docker.io. |
/hold cancel |
/retest |
/unassign |
/retest |
/test all |
/retest |
/approve |
/lgtm |
typo? |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cyril-ui-developer, spadgett, yselkowitz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Is there a reason the analyze test keeps failing? |
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold |
/hold cancel |
@yselkowitz: All pull requests linked via external trackers have merged:
Bugzilla bug 1766287 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The new imagestream was missing a lookupPolicy setting which prevented
it from being a drop-in replacement of the image on Docker Hub. With
that fixed in the Samples operator, only the annotations are needed from
commit eee9a0c.
This is dependent on openshift/cluster-samples-operator#350
/hold
/assign @cyril-ui-developer