Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1899627: Update project status icon and text in the dashboard Status panel to match health-item display #7849

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Bug 1899627: Update project status icon and text in the dashboard Status panel to match health-item display #7849

merged 1 commit into from
Jan 19, 2021

Conversation

sg00dwin
Copy link
Member

Changes to project status Icon and text sizes and spacing with Image Vulnerabilities.

  • Wrap with <Gallery> component to match Admin overview status panel.
  • Remove frontend/public/components/dashboard/project-dashboard/status-card.scss styles and use .co-status-card__health-item for positioning, same as < ResourceHealthItem>

Nested .co-icon-and-text--lg .co-icon-and-text__icon rule needed to set size and spacing.

fix https://bugzilla.redhat.com/show_bug.cgi?id=1899627

cc @itsptk

Before
Screen Shot 2021-01-15 at 10 27 51 AM

After
Screen Shot 2021-01-13 at 4 50 00 PM copy

Overview Dashboard
Screen Shot 2021-01-15 at 10 37 08 AM

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jan 15, 2021
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Bugzilla bug 1899627, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1899627: Update project status icon and text in the dashboard Status panel to match health-item display

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. component/core Related to console core functionality labels Jan 15, 2021
@openshift-ci-robot openshift-ci-robot added component/dashboard Related to dashboard component/shared Related to console-shared labels Jan 15, 2021
@sg00dwin
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 15, 2021
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Bugzilla bug 1899627, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto
rhamilto reviewed Jan 15, 2021
View reviewed changes
frontend/packages/console-shared/src/components/dashboard/dashboard-card/card.scss Outdated
@@ -1,6 +1,8 @@
@import '~@patternfly/patternfly/sass-utilities/colors';

$co-dashboard-card--line-height: 19px;
$co-dashboard-icon-font-size: 1.2rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, I think it's better for this to be renamed to move to _icon-and-text.scss and be imported here rather than the other way around.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated pr

@sg00dwin sg00dwin force-pushed the project-status-bug1899627 branch 2 times, most recently from 60a1694 to 6e0d2a2 Compare January 15, 2021 19:05
@itsptk
Copy link

itsptk commented Jan 15, 2021

Thanks @sg00dwin , LGTM!

rhamilto
rhamilto reviewed Jan 15, 2021
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. Otherwise LGTM.

frontend/public/components/_icon-and-text.scss Outdated Show resolved Hide resolved
rhamilto
rhamilto approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sg00dwin
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bfc34d2 into openshift:master Jan 19, 2021
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: All pull requests linked via external trackers have merged:

Bugzilla bug 1899627 has been moved to the MODIFIED state.

In response to this:

Bug 1899627: Update project status icon and text in the dashboard Status panel to match health-item display

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sg00dwin sg00dwin deleted the project-status-bug1899627 branch January 19, 2021 17:52
@spadgett spadgett added this to the v4.7 milestone Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@rawagner rawagner Awaiting requested review from rawagner

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sg00dwin @openshift-ci-robot @itsptk @openshift-bot @rhamilto @spadgett @openshift-merge-robot