New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1921258: use sessionStorage for user-settings when impersonating #7958
Bug 1921258: use sessionStorage for user-settings when impersonating #7958
Conversation
843e955
to
dc240f4
Compare
@christianvogt: This pull request references Bugzilla bug 1921258, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dc240f4
to
d0f4605
Compare
@christianvogt Verified it i no longer observed Switch in perspective when tried on one window with impersonate and another with kubeadmin. Storing in session works as expected in chrome however in safari it doesn't seems to work as expected. That looks like a separate issue LMK if needed will log one |
@invincibleJai thanks. I cannot test safari until i update my OS since my safari is too old and doesn't support |
i verified again and it works fine in Safari as well earlier i was trying to look in storage and din't seem to get it reflect there then but seems fine now |
@christianvogt: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
d0f4605
to
527595b
Compare
@invincibleJai that's for the review and test. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, invincibleJai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@christianvogt: All pull requests linked via external trackers have merged: Bugzilla bug 1921258 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Analysis / Root cause:
When logged in as kubeadmin and impersonating a user, the access to the user-settings configmap for kubeadmin returns a 403 which puts the user settings hook in a bad state and will update whenever another tab is opened for the kubeadmin user and their settings are updated.
Solution Description:
When impersonating a user, use session storage as the backing store instead of configmap or local storage.
Screen shots / Gifs for design review:
No UI change.
Unit test coverage report:
Added unit test which checks for session storage usage when impersonating.
Browser conformance: