Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODC-5596-Updated cypress extensibility related files #8305

Merged
merged 1 commit into from Mar 9, 2021
Merged

ODC-5596-Updated cypress extensibility related files #8305

merged 1 commit into from Mar 9, 2021

Conversation

makambalaji
Copy link
Contributor

  • Update the pacakge.json file with below scripts

test-cypress-pipelines-headless & test-cypress-pipelines
test-cypress-knative-headless & test-cypress-knative
test-cypress-gitops-headless & test-cypress-gitops

  • Update the .gherkinlintrc file

updated knative related tags
max scenarios per file
file name style

  • Updated the OWNERS file for gitops, knative and pipelines

@openshift-ci-robot openshift-ci-robot added the component/gitops Related to gitops-plugin label Mar 4, 2021
@openshift-ci-robot openshift-ci-robot added component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Mar 4, 2021
@makambalaji
Copy link
Contributor Author

VeereshAardhaya raised a request to join openshift.org, I think approval is not done yet. due to that reason do-not-merge/invalid-owners-file label is added.until then marking this pr as hold
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
dtaylor113
dtaylor113 reviewed Mar 5, 2021
View reviewed changes
frontend/package.json
"test-cypress-gitops": "cd packages/gitops-plugin/integration-tests && ../../../node_modules/.bin/cypress open --env openshift=true",
"test-cypress-gitops-headless": "cd packages/gitops-plugin/integration-tests && node --max-old-space-size=4096 ../../../node_modules/.bin/cypress run --env openshift=true --browser ${BRIDGE_E2E_BROWSER_NAME:=chrome} --headless --spec \"features/*/*.feature\";",
"test-cypress-knative": "cd packages/knative-plugin/integration-tests && ../../../node_modules/.bin/cypress open --env openshift=true",
"test-cypress-knative-headless": "cd packages/knative-plugin/integration-tests && node --max-old-space-size=4096 ../../../node_modules/.bin/cypress run --env openshift=true --browser ${BRIDGE_E2E_BROWSER_NAME:=chrome} --headless --spec \"features/*/*.feature\";",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, are any of these supposed to run during CI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Dave, below are the scripts needs to be executed on CI, but I don't want to run them on all pr's
test-cypress-gitops-headless [This should run, only when gitOps label is added to the pr]
test-cypress-knative-headless [This should run, only when knative label is added to the pr]
I will raise this ci implementation as separate pr

@makambalaji makambalaji mentioned this pull request Mar 5, 2021
Closed
@makambalaji
Copy link
Contributor Author

/hold cancel
Removing hold, as 'do-not-merge/invalid-owners-file' label is already added

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2021
@VeereshAradhya
Copy link
Contributor

Created a ticket https://issues.redhat.com/browse/DPP-6910

@makambalaji makambalaji mentioned this pull request Mar 8, 2021
Merged
@makambalaji
Copy link
Contributor Author

/verify-owners

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 8, 2021
@VeereshAradhya
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

@VeereshAradhya: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2021
@VeereshAradhya
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, jerolimov, makambalaji, VeereshAradhya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8fe2df7 into openshift:master Mar 9, 2021
@spadgett spadgett added this to the v4.8 milestone Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtaylor113 dtaylor113 dtaylor113 left review comments

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@gajanan-more gajanan-more Awaiting requested review from gajanan-more

Assignees

@jerolimov jerolimov

@VeereshAradhya VeereshAradhya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/gitops Related to gitops-plugin component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@makambalaji @VeereshAradhya @openshift-ci-robot @jerolimov @openshift-bot @andrewballantyne @dtaylor113 @spadgett @openshift-merge-robot