-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.7] Bug 1944349: fix backwards incompatible trigger api changes #8503
[release-4.7] Bug 1944349: fix backwards incompatible trigger api changes #8503
Conversation
@karthikjeeyar: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@karthikjeeyar: This pull request references Bugzilla bug 1944349, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @andrewballantyne |
frontend/packages/pipelines-plugin/src/components/pipelines/modals/triggers/resource-utils.ts
Outdated
Show resolved
Hide resolved
87db636
to
274c9b1
Compare
@karthikjeeyar: This pull request references Bugzilla bug 1944349, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
274c9b1
to
0288047
Compare
@karthikjeeyar I notice that Removal of Triggers has some issue and need to fix. |
Thanks @vikram-raj, I have fixed removal issue and pushed here. |
0288047
to
93d92b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify the changes with the 1.3 and 1.4 pipeline operators.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with 1.4.0 and 1.3.1 - both are able to create triggers, remove triggers and the trigger can successfully fire off with my simple UI test files.
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 1944349, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
93d92b4
to
4c12a20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, karthikjeeyar, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 1944349, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@karthikjeeyar: This pull request references Bugzilla bug 1944349, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@karthikjeeyar: This pull request references Bugzilla bug 1944349, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
(patch manager) prioritized for this release to align with pipelines GA |
@karthikjeeyar: All pull requests linked via external trackers have merged: Bugzilla bug 1944349 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a manual cherry pick of #8437
Problem:
OSP 1.4 (GA version) has breaking api changes which needs to be addressed in OCP-4.7.
Solution:
Fixes the trigger API breaking changes in 1.4 OSP in OCP-4.7. Replaced
template.name
withtemplate.ref
and still support earlier versions operator to use template.name via Yaml.Screenshots:
No UI changes
Test cases:
submitTrigger
✓ expect the eventlistener to contain template.name if the operator is below GA version (1.4.0) (23ms)
✓ expect the eventlistener to contain template.ref if the operator is GA version (1.4.0) (4ms)
/kind bug