Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1942839: Image is now pulled from config map data #8549

Merged
merged 1 commit into from Apr 12, 2021
Merged

Bug 1942839: Image is now pulled from config map data #8549

merged 1 commit into from Apr 12, 2021

Conversation

metalice
Copy link
Contributor

@metalice metalice commented Apr 4, 2021

Signed-off-by: Matan Schatzman mschatzm@redhat.com

@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Apr 4, 2021
@metalice metalice changed the title Image is now pulled from config map data Bug 1942839: Image is now pulled from config map data Apr 4, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Apr 4, 2021
@openshift-ci-robot
Copy link
Contributor

@metalice: This pull request references Bugzilla bug 1942839, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1942839: Image is now pulled from config map data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 4, 2021
@metalice metalice force-pushed the bz-1942839-windows-vms-fail-to-start branch from c7d221d to b606ed1 Compare April 4, 2021 14:15
@yaacov
Copy link
Member

yaacov commented Apr 4, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 4, 2021
@metalice metalice force-pushed the bz-1942839-windows-vms-fail-to-start branch from b606ed1 to 6589246 Compare April 4, 2021 16:10
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2021
@yaacov
Copy link
Member

yaacov commented Apr 4, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2021
@yaacov
Copy link
Member

yaacov commented Apr 5, 2021

@metalice test failing is legit, needs code updat

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@metalice
Copy link
Contributor Author

metalice commented Apr 5, 2021

/test frontend

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@metalice metalice force-pushed the bz-1942839-windows-vms-fail-to-start branch from 6589246 to 3a3d692 Compare April 5, 2021 10:17
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2021
@metalice
Copy link
Contributor Author

metalice commented Apr 5, 2021

/test e2e-gcp-console

@metalice
Copy link
Contributor Author

metalice commented Apr 5, 2021

/test kubevirt-plugin

@yaacov
Copy link
Member

yaacov commented Apr 5, 2021

/retest

@yaacov
Copy link
Member

yaacov commented Apr 7, 2021

@metalice ping ^^ ?

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

22 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@yaacov
Copy link
Member

yaacov commented Apr 12, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fea832f into openshift:master Apr 12, 2021
@openshift-ci-robot
Copy link
Contributor

@metalice: All pull requests linked via external trackers have merged:

Bugzilla bug 1942839 has been moved to the MODIFIED state.

In response to this:

Bug 1942839: Image is now pulled from config map data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yaacov added a commit to yaacov/console that referenced this pull request Apr 19, 2021
@yaacov
Revert "Merge pull request openshift#8549 from metalice/bz-1942839-wi…
435d631 
…ndows-vms-fail-to-start"

This reverts commit fea832f, reversing
changes made to 330022c.
@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 21, 2021
Merged
@spadgett spadgett added this to the v4.8 milestone May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaacov yaacov yaacov left review comments

@rawagner rawagner Awaiting requested review from rawagner

@atiratree atiratree Awaiting requested review from atiratree

@gouyang gouyang Awaiting requested review from gouyang

Assignees

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@metalice @openshift-ci-robot @yaacov @openshift-bot @spadgett @openshift-merge-robot