New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1952209: Consistent formatting of dates and times #8734
Bug 1952209: Consistent formatting of dates and times #8734
Conversation
@spadgett: This pull request references Bugzilla bug 1952209, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
73ae811
to
277b775
Compare
@rhamilto I needed to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/bugzilla refresh |
@yanpzhan: This pull request references Bugzilla bug 1952209, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label qe-approved |
/lgtm |
/hold |
Consistently format dates with Intl.DateTimeFormat. This will ensure that we honor the browser's locale setting even for languages we don't yet support. Always show the year for dates. Ultimately, we want to make the date and time format a user preference.
277b775
to
d55cc3e
Compare
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, spadgett, yanpzhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@spadgett: All pull requests linked via external trackers have merged: Bugzilla bug 1952209 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual 4.7.z backport of #8490. This PR does not include removing moment.js, only the time format changes.
Consistently format dates with Intl.DateTimeFormat. This will ensure that we honor the browser's locale setting even for languages we don't yet support. Always show the year for dates. Ultimately, we want to make the date and time format a user preference.
/assign @rhamilto
/cc @kyoto