Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1934229: Improve performance of ToolbarFilter #8821

Merged
merged 1 commit into from Jun 7, 2021
Merged

Bug 1934229: Improve performance of ToolbarFilter #8821

merged 1 commit into from Jun 7, 2021

Conversation

TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Apr 28, 2021 •
edited

  • Debounce name filter
  • Use memoization and React lifecycle hooks to minimize re-rendering

@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request references Bugzilla bug 1934229, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1934229: Improve performance of ToolbarFilter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 28, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TheRealJon
To complete the pull request process, please assign spadgett after the PR has been reviewed.
You can assign the PR to them by writing /assign @spadgett in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Apr 29, 2021
@TheRealJon
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 29, 2021
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request references Bugzilla bug 1934229, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2021
@spadgett spadgett mentioned this pull request May 3, 2021
Closed
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2021
@TheRealJon
Copy link
Member Author

/retest

1 similar comment
@TheRealJon
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot added the kind/cypress Related to Cypress e2e integration testing label May 6, 2021
@TheRealJon
Copy link
Member Author

/cc @spadgett

@openshift-ci openshift-ci bot requested a review from spadgett May 10, 2021 20:16
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2021
@TheRealJon
Copy link
Member Author

/retest

spadgett
spadgett reviewed May 21, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jon, thanks. Code looks good overall.

I notice when testing that the first keystroke updates immediately, and then it waits until you pause. That seemed a little strange. It might be better to use the tail end of the debounce instead of updating immediately on the first keystroke then waiting.

We should consider updating immediately when the filter is removed as well. If you select all -> backspace, I'd expect the page to update right away. I'm not sure if that's possible with useDebounceCallback, though.

frontend/public/components/filter-toolbar.tsx Outdated Show resolved Hide resolved
@glekner
Copy link
Contributor

glekner commented Jun 1, 2021

any update here @TheRealJon ?

@TheRealJon
Bug 1934229: Improve performance of ToolbarFilter
926735c 
- Debounce name filter
- Make row filter groups Reactive
- Row filter dropdown no longer closes on selection
- Fix console error from row filter checkboxes
- Use memoization and React lifecycle hooks to minimize re-rendering
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2021

@TheRealJon: This pull request references Bugzilla bug 1934229, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1934229: Improve performance of ToolbarFilter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon
Copy link
Member Author

@glekner Just pushed an update. @spadgett I addressed your comment and a few other things I found.

@TheRealJon
Copy link
Member Author

/retest

2 similar comments
@glekner
Copy link
Contributor

glekner commented Jun 6, 2021

/retest

@TheRealJon
Copy link
Member Author

/retest

@TheRealJon TheRealJon requested a review from spadgett June 7, 2021 20:04
spadgett
spadgett approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1fffa2c into openshift:master Jun 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2021

@TheRealJon: All pull requests linked via external trackers have merged:

Bugzilla bug 1934229 has been moved to the MODIFIED state.

In response to this:

Bug 1934229: Improve performance of ToolbarFilter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon TheRealJon deleted the 1934229 branch June 8, 2021 13:46
@spadgett spadgett added this to the v4.8 milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@kyoto kyoto Awaiting requested review from kyoto

@rhamilto rhamilto Awaiting requested review from rhamilto

@yapei yapei Awaiting requested review from yapei

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TheRealJon @openshift-ci-robot @glekner @spadgett @openshift-merge-robot