Fix node-v15 pipeline test failures #8892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewballantyne
changed the title
openshift-ci
bot
added
the
kind/cleanup
openshift-ci
bot
added
component/dev-console
|
Verified on latest node, works as expected without any errors in the output. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ODC-5824
Does two things:
jest.spyOninvokes the method with no arguments and one of our methods was incorrectly trying to test that a try/catch caught errors and mocked a situation where an undefined Pipeline object was being invoked for.metadata.nameBest guess why this is happening is this is somehow in the Node code on how to swallow some errors that jest is creating (maybe in a worker thread?) and thus when upgraded to v15 it exposes this issue instead of hiding it. There is a slack thread of others on the team testing on v14 of node and it passes as it always has -- see the ticket for that thread.